Skip to content

Migration to JUnit 5 - avoid using AbstractMojoTestCase#447

Merged
slawekjaranowski merged 1 commit into
apache:maven-resources-plugin-3.xfrom
slawekjaranowski:junit5-01
Dec 2, 2025
Merged

Migration to JUnit 5 - avoid using AbstractMojoTestCase#447
slawekjaranowski merged 1 commit into
apache:maven-resources-plugin-3.xfrom
slawekjaranowski:junit5-01

Conversation

@slawekjaranowski

Copy link
Copy Markdown
Member

also:

  • refactor PropertyUtilsTest - it is not Mojo test, move use cases from advanced amd enhanced examples

  • CopyResourcesMojoTest - test copy-resources instead of resources goal, add more tests for filtered and not filtered resources


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Comment thread src/test/java/org/apache/maven/plugins/resources/PropertyUtilsTest.java Outdated
Comment thread pom.xml
also:
- refactor PropertyUtilsTest - it is not Mojo test, move use cases from advanced amd enhanced examples

- CopyResourcesMojoTest - test copy-resources instead of resources goal, add more tests for filtered and not filtered resources
@slawekjaranowski
slawekjaranowski merged commit 1e59b45 into apache:maven-resources-plugin-3.x Dec 2, 2025
11 checks passed
@slawekjaranowski
slawekjaranowski deleted the junit5-01 branch December 2, 2025 19:23
@github-actions github-actions Bot added this to the 3.4.1 milestone Dec 2, 2025
@github-actions

github-actions Bot commented Dec 2, 2025

Copy link
Copy Markdown

@slawekjaranowski Please assign appropriate label to PR according to the type of change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants