Skip to content

services: Add full memory support #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2022
Merged

services: Add full memory support #134

merged 3 commits into from
Mar 10, 2022

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Mar 10, 2022

Signed-off-by: Xuanwo [email protected]

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/.

Summary

This PR intends to add essential memory support to have a baseline to get started.

We have a simple memory backend support via HashMap<String, bytes::Bytes> based on @sundy-li 's work.

  • Behavior tests have been passed.
  • Benches have been set up.
  • CI has been set up (a good start for the future enhancement)

@Xuanwo Xuanwo requested a review from sundy-li March 10, 2022 08:31
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo requested a review from dantengsky March 10, 2022 08:42
Copy link

@dantengsky dantengsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xuanwo Xuanwo merged commit b9c1fcb into apache:main Mar 10, 2022
@Xuanwo Xuanwo deleted the memory branch June 13, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants