Skip to content

fix(services/s3,hdfs): List empty dir should not return itself #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2022

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jun 2, 2022

Signed-off-by: Xuanwo [email protected]

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

fix(s3): List empty dir could return itself

Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo changed the title fix(services/s3): List empty dir could return itself fix(services/s3): List empty dir should not return itself Jun 2, 2022
@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 2, 2022

HDFS test failed

[2022-06-02T13:55:38Z DEBUG opendal::services::hdfs::backend] object /8625802f-8271-43a6-9b74-a93466834ce4/ad7e3f9c-efac-4955-bf08-e5103229a49b/ create dir
[2022-06-02T13:55:38Z DEBUG opendal::services::hdfs::backend] object /8625802f-8271-43a6-9b74-a93466834ce4/ad7e3f9c-efac-4955-bf08-e5103229a49b/ list start
[2022-06-02T13:55:38Z ERROR opendal::services::hdfs::backend] object /8625802f-8271-43a6-9b74-a93466834ce4/ad7e3f9c-efac-4955-bf08-e5103229a49b/ list: Custom { kind: NotFound, error: ObjectError { op: "list", path: "/8625802f-8271-43a6-9b74-a93466834ce4/ad7e3f9c-efac-4955-bf08-e5103229a49b/", source: No such file or directory (os error 2) } }
Error: object error: (op: list, path: /8625802f-8271-43a6-9b74-a93466834ce4/ad7e3f9c-efac-4955-bf08-e5103229a49b/, source: No such file or directory (os error 2))

Caused by:
    No such file or directory (os error 2)
thread 'behavior::hdfs::test_list_empty_dir' panicked at 'assertion failed: `(left == right)`

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 2, 2022

hdrs doesn't handle errno correctly, we need to fix it

Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo changed the title fix(services/s3): List empty dir should not return itself fix(services/{s3,hdfs}): List empty dir should not return itself Jun 3, 2022
@Xuanwo Xuanwo changed the title fix(services/{s3,hdfs}): List empty dir should not return itself fix(services/s3,hdfs): List empty dir should not return itself Jun 3, 2022
@Xuanwo Xuanwo merged commit ddbc8e0 into main Jun 3, 2022
@Xuanwo Xuanwo deleted the fix-s3-list-empty-dir branch June 3, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant