feature: Google Cloud Storage support skeleton #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. try implement GCS support backend prototype 2. try implement GCS support directory walker prototype Signed-off-by: ClSlaid <[email protected]>
|
This PR is still working in progress, tasks to complete:
|
Add Apache license headers for gcs files Signed-off-by: ClSlaid <[email protected]>
Please create a tracking issue for this. I prefer to merge multiple PRs instead of one. |
5 tasks
ClSlaid
changed the title
Xuanwo
reviewed
Aug 12, 2022
1. canceled unneccesary feature switch `service-gcs` 2. implement from_iter() for `gcs::Backend` 3. *make gcs compile* Signed-off-by: ClSlaid <[email protected]>
added some document comments in gcs Signed-off-by: ClSlaid <[email protected]>
Xuanwo
reviewed
Aug 12, 2022
now it should be able to compiled and satisfies clippy Signed-off-by: ClSlaid <[email protected]>
Signed-off-by: ClSlaid <[email protected]>
Xuanwo
reviewed
Aug 14, 2022
now the backend should inherits the default implementation of Accessor Signed-off-by: ClSlaid <[email protected]>
Signed-off-by: ClSlaid <[email protected]>
Signed-off-by: ClSlaid <[email protected]>
Xuanwo
reviewed
Aug 15, 2022
Signed-off-by: ClSlaid <[email protected]>
Signed-off-by: ClSlaid <[email protected]>
Signed-off-by: ClSlaid <[email protected]>
Xuanwo
reviewed
Aug 15, 2022
|
Please mark the conversation as resolved after fixing. |
Signed-off-by: ClSlaid <[email protected]>
|
@Xuanwo PTAL! ;) |
Signed-off-by: ClSlaid <[email protected]>
Xuanwo
reviewed
Aug 15, 2022
Signed-off-by: ClSlaid <[email protected]>
Xuanwo
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will complete #7.
Signed-off-by: ClSlaid [email protected]
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/