Skip to content

feat: Implement huaweicloud obs service other op support #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 23, 2022
Merged

feat: Implement huaweicloud obs service other op support #557

merged 11 commits into from
Aug 23, 2022

Conversation

teckick
Copy link
Contributor

@teckick teckick commented Aug 22, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

This PR implements Huaweicloud OBS service: list, delete, stat.

Related to #512

@teckick teckick marked this pull request as draft August 22, 2022 12:09
@Xuanwo
Copy link
Member

Xuanwo commented Aug 22, 2022

Hi, I'm working a refactor at #556 which expected to be merged tomorrow. RFC could be found here: https://opendal.databend.rs/rfcs/0554-write-refactor.html. I believe this change will make our services easier to be implemented.

So can you leave create and write as todo!() so that we don't need to migrate it again?

@teckick
Copy link
Contributor Author

teckick commented Aug 22, 2022

ok

@Xuanwo Xuanwo self-requested a review August 22, 2022 16:14
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, mostly LGTM!

@teckick teckick marked this pull request as ready for review August 23, 2022 01:31
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, you are my hero of the today!

@Xuanwo Xuanwo merged commit d5f58d7 into apache:main Aug 23, 2022
@teckick teckick deleted the dev-obs-other-op branch August 23, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants