Skip to content

feat: Implement obs create and write #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 25, 2022
Merged

feat: Implement obs create and write #565

merged 4 commits into from
Aug 25, 2022

Conversation

teckick
Copy link
Contributor

@teckick teckick commented Aug 25, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Implement obs create and write

Related to #512

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.

@teckick
Copy link
Contributor Author

teckick commented Aug 25, 2022

Please wait a moment, local commit has not been pushed due to network error.

@teckick
Copy link
Contributor Author

teckick commented Aug 25, 2022

Fixed, PTAL

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far! Thanks for your contribution.

@Xuanwo
Copy link
Member

Xuanwo commented Aug 25, 2022

Please update the branch with the latest main before merging.

@Xuanwo Xuanwo merged commit 475fde6 into apache:main Aug 25, 2022
@teckick teckick deleted the dev-obs-write branch August 26, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants