-
Notifications
You must be signed in to change notification settings - Fork 621
feat: improve observability of BytesReader
and DirStreamer
#603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ClSlaid <[email protected]>
DirStreamer has nothing to record, won't do. Signed-off-by: ClSlaid <[email protected]>
Signed-off-by: ClSlaid <[email protected]>
Signed-off-by: ClSlaid <[email protected]>
rustfmt confirmed that we get the same format (you will find the check didn't pass) You can try this way:
|
By "complete format" I mean uncommeting all lines in rustfmt.toml and running Sadly, the default rustfmt style is not the same as databend. I should have checked before pushing. :( |
Because OpenDAL should be run on stable rust, we can't use the same
Don't worry. CI is always here until you make them happy. |
Some more comments about statements like those Don't worry about revokable errors: Everything is OK. It's just a simple mistake and is detected by CI. No one should be blamed here, especially in open-source projects like OpenDAL. I don't care about any mistakes that could be detected by CI, like styling and formatting. But I do care:
Let's focus on the essential part and let our CI worry about those slight mistakes. |
Signed-off-by: ClSlaid <[email protected]>
Signed-off-by: ClSlaid <[email protected]>
Signed-off-by: ClSlaid <[email protected]>
Signed-off-by: ClSlaid <[email protected]>
Signed-off-by: ClSlaid <[email protected]>
1. typo fixes and remove unnecessary comment 2. changed HDFS's DirStream Signed-off-by: ClSlaid <[email protected]>
Signed-off-by: ClSlaid <[email protected]>
Signed-off-by: ClSlaid <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now!
Thanks for your patience~
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Why are so many files edited?
My code format was a mess so I ran a complete format...
Summary
By wrapping
BytesReader
andDirStreamer
in a way like layers in v0.13.0, a leap of observability is done.LoggingReader
andLoggingStreamer
, whenAccessor::read
,Accessor::write
,Accessor::list
andAccessor::write_multipart()
TracingReader
andTracingStreamer
, whenAccessor::read
,Accessor::write
,Accessor::list
andAccessor::write_multipart()
MetricReader
, whenAccessor::read
,Accessor::write
andAccessor::write_multipart()
Need discussion
Related issue