Skip to content

feat: ADLS Client Credential Authentication #6205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

c-thiel
Copy link
Contributor

@c-thiel c-thiel commented May 21, 2025

Rationale for this change

Client Credential & SAS Token Authentication is a valid authentication mechanism for ADLS and should be supported by opendal. reqsign already supports it.

What changes are included in this PR?

Add configuration options for the following parameters and pass them to reqsign:

  • client_secret
  • tenant_id
  • client_id
  • sas_token
  • authority_host

Are there any user-facing changes?

Yes, but no breaking changes. Just additional config options.

@c-thiel c-thiel requested a review from Xuanwo as a code owner May 21, 2025 07:15
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels May 21, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 21, 2025
@Xuanwo Xuanwo merged commit 2d8f623 into apache:main May 21, 2025
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants