feat(bindings/python): allow Path in root #6490
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ohh, the new clippy warning, I don't want to fix them in this pr. |
|
dosubot
bot
added
size:M
This has already been resolved and merged into main. |
asukaminato0721
force-pushed
the
root-path
branch
from
c9d609b to
4846eb3
Compare
Xuanwo
reviewed
Aug 8, 2025
| .unwrap_or_default(); | ||
| let map = if let Some(v) = map { | ||
| v.iter() | ||
| .map(|(k, v)| Ok((k.extract::<String>()?, v.str()?.to_string()))) |
There was a problem hiding this comment.
This makes me think we should expose S3Config to Python instead of just using HashMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6479.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
user can use Path in root.