refactor: remove enable_secure in FTP service.
#709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ClSlaid <[email protected]>
1. remove `enable_secure` in ftp service 2. if the endpoint begins with `ftps://`, enable_secure of suppaftp set to true NOTE: now all endpoints should be prefixed `ftp://` and `ftps://` Signed-off-by: ClSlaid <[email protected]>
Xuanwo
reviewed
Sep 25, 2022
|
Please update to branch before start new PR. |
Signed-off-by: ClSlaid <[email protected]>
Signed-off-by: ClSlaid <[email protected]>
Signed-off-by: ClSlaid <[email protected]>
There was a problem hiding this comment.
LGTM! I tested on my device and it works perfectly. Just a little suggestion, maybe we could add a bit more tests under test_build() for error condition like:
// invalid scheme
let mut builder = Builder::default();
builder.endpoint("invalidscheme://ftp_server.local:8766");
let b = builder.build();
assert!(!b.is_ok());
let expected = "backend error: (context: {}, source: endpoint scheme unsupported or invalid: \"invalidscheme\")";
assert_eq!(b.unwrap_err().to_string(), expected);
Signed-off-by: ClSlaid <[email protected]>
|
@ClSlaid are there other updates? |
Signed-off-by: ClSlaid <[email protected]>
forgot to add test on the error message, resolving git conflicts. |
…to remove-enable-tls-in-builder
Please don't... OpenDAL never relays on the error message. |
Signed-off-by: ClSlaid <[email protected]>
test on error kinds then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
enable_securein FTP service builderftps://, the backend will use TLS secured connectionNote
now all endpoints should be prefixed with
ftp://andftps://.