[ISSUE #1060] [Java] Enhance the logic of MessageInterceptor #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1061 +/- ##
============================================
- Coverage 53.26% 53.11% -0.16%
- Complexity 651 665 +14
============================================
Files 208 211 +3
Lines 14303 14039 -264
Branches 5845 5541 -304
============================================
- Hits 7619 7457 -162
+ Misses 6308 6206 -102
Partials 376 376
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lizhimins
requested changes
Aug 13, 2025
| @@ -36,6 +38,11 @@ public class LoggingInterceptor implements ClientInterceptor { | |||
| private static final Logger log = LoggerFactory.getLogger(LoggingInterceptor.class); | |||
|
|
|||
| private static final LoggingInterceptor INSTANCE = new LoggingInterceptor(); | |||
| private static String remoteAddr = ""; | |||
|
|
|||
| public static String getRemoteAddr() { | |||
qianye1001
reviewed
Aug 13, 2025
| @@ -36,6 +38,11 @@ public class LoggingInterceptor implements ClientInterceptor { | |||
| private static final Logger log = LoggerFactory.getLogger(LoggingInterceptor.class); | |||
|
|
|||
| private static final LoggingInterceptor INSTANCE = new LoggingInterceptor(); | |||
| private static String remoteAddr = ""; | |||
There was a problem hiding this comment.
using static not support muti client instance
qianye1001
reviewed
Aug 13, 2025
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class ConsumeTask implements Callable<ConsumeResult> { | ||
| private static final Logger log = LoggerFactory.getLogger(ConsumeTask.class); | ||
|
|
||
| private static final String MESSAGE_VIEW_CONTEXT = "messageView"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #1060
Brief Description
Added MessageInterceptorContext information to provide more comprehensive information to the MessageInterceptor, including the remote address, messages sent by the producer, messages received, message type, consumption exceptions, and more.