escalate: Add x-escalate-redirect header (#1092) #12447
Merged
+85
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shukitchan
previously approved these changes
Aug 12, 2025
|
Looks good, though my only question would be do we want to enable this new behavior by default? Since it would be changing how this acts for current users, rather than just making it disabled by default |
ezelkow1
previously approved these changes
Aug 15, 2025
If the escalate.so plugin escalates a request, add the x-escalate-redirect header as an indicator that it did so. Adding the header can be disabled via: @pparam=--no-redirect-header
bneradt
force-pushed
the
escalate_add_x_header
branch
from
41fe93a to
1e057ea
Compare
cmcfarlen
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the escalate.so plugin escalates a request, add the x-escalate-redirect header as an indicator that it did so. Adding the header can be disabled via: @pparam=--no-redirect-header