escalate.so: --escalate-non-get-methods #12448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement --escalate-non-get-methods for the escalate plugin. By default, only GET methods are escalated because typical failover servers are caches of the original and cannot handle non-idempotent requests. However, for situations where non-GET is supported, this method allows the admin to escalate those requests as well.
bneradt
force-pushed
the
escalate_non_get_methods
branch
from
8ac0fa3 to
c8c4939
Compare
shukitchan
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement --escalate-non-get-methods for the escalate plugin. By default, only GET methods are escalated because typical failover servers are caches of the original and cannot handle non-idempotent requests. However, for situations where non-GET is supported, this method allows the admin to escalate those requests as well.
This replaces #12438: the concept is similar, but with this PR the default behavior is to avoid redirecting non-GET methods with the option provided to escalate them if wanted.