Skip to content

fix: TargetPodSelector for 'Any' and 'All' should exclude those kbagent not ready #9582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: TargetPodSelector for 'Any' and 'All' should exclude those kbagent not ready #9582

wants to merge 2 commits into from

Conversation

lancelot1989
Copy link
Contributor

resolves #9579

@lancelot1989 lancelot1989 requested a review from a team as a code owner July 31, 2025 03:50
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Jul 31, 2025
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

@apecloud-bot apecloud-bot added the pre-approve Fork PR Pre Approve Test label Jul 31, 2025
@zjx20
Copy link
Contributor

zjx20 commented Aug 1, 2025

@leon-inf PTAL.

leon-inf
leon-inf requested changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@leon-inf leon-inf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not change the semantics of "any" and "all". When selecting source replicas, simply remove the new replicas from the pods list.

@apecloud-bot apecloud-bot added pre-approve Fork PR Pre Approve Test and removed pre-approve Fork PR Pre Approve Test labels Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leon-inf leon-inf leon-inf requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
pre-approve Fork PR Pre Approve Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]KubeBlocks may select new replica itself as DataDump target if none targetPodSelector is set
4 participants
@lancelot1989 @apecloud-bot @zjx20 @leon-inf