Speed up sessions/bridge-resilience e2e test to fix Windows timeout#267
Merged
Conversation
This test ran nearly every check through run_xmcpc, which spawns 5 mcpc processes (the command plus 4 --json/--verbose invariant-check variants). With ~17 such calls on live-bridge session commands it did ~90 process spawns and took ~180s on Linux — right at the per-test watchdog limit, and over it on Windows, where the slower spawns made test 10 time out (exit 137). Switch the checks to run_mcpc (one spawn each). This test is about bridge resilience, not output-format invariants, which are already covered by basic/output-invariants (the invariant machinery) and basic/errors / basic/auth-errors (the --json error path). Runtime drops from ~180s to ~19s with no loss of resilience coverage. https://claude.ai/code/session_01TFGKjwkFNC1oupR2jEg2C8
The previous commit converted every check to run_mcpc, which dropped this suite's output-invariant coverage on live-bridge MCP commands. Restore two run_xmcpc calls — one success path (tools-list) and one error path (tools-call on an unknown tool) — so the --json/--verbose invariants stay covered on a real bridge, while the rest stays on single-spawn run_mcpc. Still fast: ~30 process spawns (was ~90), ~30s locally and well under the 180s per-test watchdog on Windows. All 10 cases pass. https://claude.ai/code/session_01TFGKjwkFNC1oupR2jEg2C8
jancurn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
sessions/bridge-resiliencee2e test timing out on Windows (exit 137). It ran nearly every check throughrun_xmcpc, which spawns 5 mcpc processes each (the command plus 4--json/--verboseinvariant variants) — ~90 spawns total, making this the slowest e2e test at ~180s, right at the per-test watchdog and over it on Windows.run_mcpcfor the resilience checks (this test's actual purpose)run_xmcpccalls — one success, one error path — so live-bridge output invariants stay covered (also covered bybasic/output-invariants)https://claude.ai/code/session_01TFGKjwkFNC1oupR2jEg2C8