Move login flag validation tests to dedicated test suite#278
Merged
Conversation
basic/auth-errors had grown to 24 cases, 16 of them run_xmcpc (which runs each command 5x to check output invariants). Under --parallel 6 the cumulative cost pushed the file past the 180s e2e watchdog, killing it mid-run on Node CI. Most of that work was CLI-side `login` flag validation (client registration approaches, CIMD, --callback-host/--callback-port) that never touches the network or test server. basic/login-flags already exists for exactly these tests, with a header noting they live there to keep auth-errors within its time budget. Move them there and: - collapse the five separate `mcpc help login` invocations into one - use single-invocation run_mcpc for the message assertions, keeping one run_xmcpc to spot-check the --json/--verbose invariant for the validation-error path auth-errors now runs ~33s (8 cases) and login-flags ~16s (16 cases); both stay well under the watchdog under parallel load. No coverage removed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019aHvfttodfoVNsVeiYgQHQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
basic/auth-errorshad grown to 24 cases (16 usingrun_xmcpc, which runs each command 5×); under--parallel 6the cumulative cost pushed it past the 180s e2e watchdog, failing Node CI. Most of that was CLI-sideloginflag validation that never hits the network — andbasic/login-flagsalready exists for exactly those tests. This moves them there with no loss of coverage.--callback-host/--callback-portvalidation intobasic/login-flagsmcpc help logininvocations into onerun_xmcpcto spot-check the--json/--verboseinvariant; use single-invocationrun_mcpcfor the restauth-errorsnow ~33s/8 cases,login-flags~16s/16 cases — both well under the watchdoghttps://claude.ai/code/session_019aHvfttodfoVNsVeiYgQHQ