Fix logTarget to avoid printing prefix when session not found#56
Merged
Conversation
When a session doesn't exist, logTarget fell through to the HTTP fallback path and printed `[→ @name (HTTP)]` before the actual error. Now it returns early for session targets that aren't found. https://claude.ai/code/session_01FLZpnvfdPy6kbPmHcarxEF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed
logTargetfunction to prevent printing a misleading session prefix when a session doesn't exist. Now only the error message is displayed to the user.Changes
returnstatement inlogTargetoutside theif (session)block so it executes regardless of whether a session is found[→ @name (HTTP)]prefix from being printed when no session existsImplementation Details
The fix is a simple control flow adjustment: the
returnstatement that was inside theif (session)block (only executing when a session exists) is now placed after the block, ensuring it always executes. This allows the error handling logic downstream to properly display error messages without the misleading session prefix being printed first.https://claude.ai/code/session_01FLZpnvfdPy6kbPmHcarxEF