Skip to content

refactor(fs): use underlyingPath to determine virtual files more reliably #9302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Aug 1, 2025

Description

Previously, empty virtual files (with zero length) were not recognized as virtual, causing errors when opening or calling Stat on them. This was due to virtual files being identified based on their size. This PR changes the criteria: a file is now considered virtual if it has no underlyingPath.

We can safely rely on underlyingPath to determine whether a file is virtual because files are created in only a limited number of controlled ways:
• Writing a real file: underlyingPath is required and an error is returned if it’s missing.
• Writing a virtual file: underlyingPath is intentionally left empty.
• Creating a virtual directory: underlyingPath is also empty in this case.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin added the autoready Automatically mark PR as ready for review when all checks pass label Aug 1, 2025
@github-actions github-actions bot marked this pull request as ready for review August 1, 2025 13:11
@github-actions github-actions bot removed the autoready Automatically mark PR as ready for review when all checks pass label Aug 1, 2025
@github-actions github-actions bot requested a review from knqyf263 as a code owner August 1, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant