refactor(fs): use underlyingPath to determine virtual files more reliably #9302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, empty virtual files (with zero length) were not recognized as virtual, causing errors when opening or calling Stat on them. This was due to virtual files being identified based on their size. This PR changes the criteria: a file is now considered virtual if it has no underlyingPath.
We can safely rely on underlyingPath to determine whether a file is virtual because files are created in only a limited number of controlled ways:
• Writing a real file: underlyingPath is required and an error is returned if it’s missing.
• Writing a virtual file: underlyingPath is intentionally left empty.
• Creating a virtual directory: underlyingPath is also empty in this case.
Checklist