feat: account resource/data source #683
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakepettersson
force-pushed
the
feature/add-account-resource
branch
2 times, most recently
from
4183455 to
96743bf
Compare
|
Would it be possible that you implement the new resource and data source directly with the new approach using HashiCorp's plugin framework instead of SDKv2? Otherwise even more human resources are required to migrate the code for all existing resources: You can find already 1 data source and 1 resource using the new approach:
It's not a blocker for me as we still were unsuccessful with the migration of: |
| enabled = data.argocd_account.admin.enabled | ||
| capabilities = data.argocd_account.admin.capabilities | ||
| tokens = data.argocd_account.admin.tokens | ||
| } |
There was a problem hiding this comment.
output "admin_account_info" {
value = {
name = data.argocd_account.admin.name
enabled = data.argocd_account.admin.enabled
capabilities = data.argocd_account.admin.capabilities
tokens = data.argocd_account.admin.tokens
}
sensitive = true
}
a070f0a to
8dbe6e6
Compare
This commit adds the possibility to create an account, as well as retrieving an account as a data source. Signed-off-by: Blake Pettersson <[email protected]>
Signed-off-by: Blake Pettersson <[email protected]>
For the new account resource and data source, move to `terraform-plugin-framework`. I also took the opportunity to migrate the `account_token` resource since the tests indirectly depended on `account_token`. Signed-off-by: Blake Pettersson <[email protected]>
Signed-off-by: Blake Pettersson <[email protected]>
Signed-off-by: Blake Pettersson <[email protected]>
Signed-off-by: Blake Pettersson <[email protected]>
Signed-off-by: Blake Pettersson <[email protected]>
blakepettersson
force-pushed
the
feature/add-account-resource
branch
from
df640f5 to
f162149
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the possibility to create an account, as well as retrieving an account as a data source.