feat: Add support for creating a configmap semaphore config using CLI. Fixes #14671 #14724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Fixes argoproj#14671 Signed-off-by: Darko Janjic <[email protected]>
…Fixes argoproj#14671 Signed-off-by: Darko Janjic <[email protected]>
…Fixes argoproj#14671 Signed-off-by: Darko Janjic <[email protected]>
…Fixes argoproj#14671 Signed-off-by: Darko Janjic <[email protected]>
…Fixes argoproj#14671 Signed-off-by: Darko Janjic <[email protected]>
…Fixes argoproj#14671 Signed-off-by: Darko Janjic <[email protected]>
…Fixes argoproj#14671 Signed-off-by: Darko Janjic <[email protected]>
djanjic
requested review from
Joibel,
terrytangyuan and
sarabala1979
as code owners
eduardodbr
reviewed
Aug 15, 2025
| } | ||
|
|
||
| func (s *syncServer) DeleteSyncLimit(ctx context.Context, req *syncpkg.DeleteSyncLimitRequest) (*syncpkg.DeleteSyncLimitResponse, error) { | ||
| fmt.Printf("Deleting sync limit for ConfigMap %s in namespace %s with key %s\n", req.Name, req.Namespace, req.Key) |
There was a problem hiding this comment.
You can remove this print or replace it proper logging
| Use: "get", | ||
| Short: "Get a configmap sync limit", | ||
| Args: cobra.ExactArgs(1), | ||
| Example: `argo sync get configmap my-cm --key my-key`, |
There was a problem hiding this comment.
Suggested change
| Example: `argo sync get configmap my-cm --key my-key`, | |
| Example: `argo sync configmap get my-cm --key my-key`, |
the command and the method are switched
| Key: req.Key, | ||
| SizeLimit: req.SizeLimit, | ||
| }, false) | ||
| } |
There was a problem hiding this comment.
A Create doing an Update violates some API principles, is this common in the current codebase?
| return nil, sutils.ToStatusError(err, codes.Internal) | ||
| } | ||
|
|
||
| delete(cm.Data, req.Key) |
There was a problem hiding this comment.
if the deleted key is the only key in the Configmap, should the CM also be deleted? otherwise the CM will be created with no data
| ### Examples | ||
|
|
||
| ``` | ||
| argo sync get configmap my-cm --key my-key |
There was a problem hiding this comment.
Suggested change
| argo sync get configmap my-cm --key my-key | |
| argo sync configmap get my-cm --key my-key |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14671
Motivation
This adds support for creating configmap sync configuration using CLI.
Modifications
Verification
Documentation