Surface flash write failures instead of a blank error screen#150
Merged
Conversation
A dying card could leave the UI on an empty error window: the disconnect handler ran cleanup before showing anything and the real write error lost the race against the device monitor. Sync results are now checked and tagged, and the error screen always has a message.
🧪 Test BuildsVersion:
ℹ️ About these builds
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flashing to a failing microSD on Linux left a reviewer staring at an almost empty window: the backend caught the write error but the device monitor won the race and cleared the screen before the message could land. Write and sync results are now checked on all three platforms, the specific failure always takes priority over the generic disconnect one, and it surfaces as a translated message with the failing offset in all 18 languages.