Skip to content

Docs samp#764

Merged
bsipocz merged 6 commits into
astropy:mainfrom
ManonMarchand:docs-samp
Jun 11, 2026
Merged

Docs samp#764
bsipocz merged 6 commits into
astropy:mainfrom
ManonMarchand:docs-samp

Conversation

@ManonMarchand

@ManonMarchand ManonMarchand commented Jun 10, 2026

Copy link
Copy Markdown
Member

This PR does two things:

  • brings the documentation from astropy
  • edits the hub's metadata to reflect that it is a PyVO hub and not an astropy one anymore

@codecov

codecov Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.29%. Comparing base (5f2f110) to head (3554ca3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #764   +/-   ##
=======================================
  Coverage   80.29%   80.29%           
=======================================
  Files          90       90           
  Lines       10249    10249           
=======================================
  Hits         8229     8229           
  Misses       2020     2020

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ManonMarchand

ManonMarchand commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

If someone can find where this reference to xmlrpc.client.Error could be that'd be lovely because I don't see it

bsipocz
bsipocz approved these changes Jun 10, 2026
View reviewed changes

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a possible fix for the docs build and also a minor edit from the changes I started to do this afternooon for this same docs port.

If CI is indeed fix, please go ahead and merge.

Comment thread docs/samp/index.rst Outdated
@bsipocz bsipocz added this to the v1.9.1 milestone Jun 10, 2026
@bsipocz

bsipocz commented Jun 11, 2026

Copy link
Copy Markdown
Member

CI failure is an enigma and I'm fixing/working around it in a separate PR.

Thanks again Manon!

@bsipocz bsipocz merged commit 554501a into astropy:main Jun 11, 2026
18 of 20 checks passed
@ManonMarchand ManonMarchand deleted the docs-samp branch June 11, 2026 09:04
@pllim pllim mentioned this pull request Jun 23, 2026
Merged
1 task
pllim
pllim reviewed Jun 23, 2026
View reviewed changes
Comment thread pyvo/samp/hub.py
"author.name": "The Astropy Collaboration",
"samp.documentation.url": "https://docs.astropy.org/en/stable/samp",
"author.name": "The PyVO Collaboration",
"samp.documentation.url": "https://pyvo.readthedocs.io/en/latest/dal/",

@pllim pllim Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the samp URL point to dal? Shouldn't it be samp?

@bsipocz bsipocz Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap, that's a typo

@pllim pllim Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, please review #770

@pllim pllim mentioned this pull request Jun 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim left review comments
@bsipocz bsipocz bsipocz approved these changes

Assignees

No one assigned

Labels

component: samp documentation no-changelog-entry-needed

Projects

None yet

Milestone

v1.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@ManonMarchand @bsipocz @pllim