chore: Latest malloy + other deps#151
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project to newer Malloy and related frontend/tooling dependencies, then adjusts application code and tests to match the updated Malloy APIs and Vitest/Vite behavior.
Changes:
- Bumps Malloy, DuckDB WASM, React Router, Vite/Vitest, TypeScript, and related dev dependencies.
- Updates Malloy API usage (e.g.,
model.queries().named,annotations.parseAsTag()) across UI and schema extraction code. - Tweaks Vite config defaults for
testmode and updates tests to disable concurrency using Vitest’s newerdescribe(..., { concurrent: false })style.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
vite.config.ts |
Treats test mode like development for default SITE_URL and removes an optimizeDeps override. |
tests/notebook-parser.test.ts |
Replaces describe.sequential with describe(..., { concurrent: false }). |
src/SourceExplorer.tsx |
Changes how draftQuery is synchronized with route loader data. |
src/Schema.tsx |
Switches “named queries” representation to string names and updates click handling/types accordingly. |
src/schema-utils.ts |
Migrates tag parsing to annotations.parseAsTag(). |
src/ModelHome.tsx |
Updates query list source to model.queries().named and adjusts navigation behavior. |
src/MalloyCodeBlock.tsx |
Removes an unnecessary type cast when passing langs to Shiki. |
src/llms-txt/schema-extractor.ts |
Updates named query extraction and tag parsing for LLM schema output. |
src/helpers.ts |
Adjusts error propagation in compileAndRun. |
src/Breadcrumbs.tsx |
Updates query dropdown source to model.queries().named. |
package.json |
Updates dependency versions for Malloy, Shiki, React, Vite/Vitest, TypeScript, etc. |
models/superstore.malloy |
Switches from duckdb.table(...) to duckdb.sql(...) for the Superstore dataset source. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+71
to
+74
| if (routeData.parsedQuery !== prevParsedQuery) { | ||
| setPrevParsedQuery(routeData.parsedQuery); | ||
| setDraftQuery(routeData.parsedQuery); | ||
| }, [routeData.parsedQuery]); | ||
| } |
+ Pin playwright to 1.60 + Use github reporter for debugging CI failures
| import { parseNotebook, extractNotebookSources } from "../src/notebook-parser"; | ||
|
|
||
| describe.sequential("parsing notebooks", () => { | ||
| describe("parsing notebooks", { concurrent: false }, () => { |
| }); | ||
|
|
||
| describe.sequential("extracting notebook sources", () => { | ||
| describe("extracting notebook sources", { concurrent: false }, () => { |
| <QueryItem | ||
| key={queryName} | ||
| query={queryName} | ||
| path={queryName} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.