UPSTREAM PR #18042: model: support GLM4V vision encoder#570
Open
loci-dev wants to merge 27 commits into
Open
Conversation
loci-dev
force-pushed
the
main
branch
4 times, most recently
from
December 15, 2025 13:21
d582acc to
4b559d8
Compare
loci-dev
force-pushed
the
main
branch
4 times, most recently
from
December 15, 2025 19:09
79099fb to
4664cb4
Compare
loci-dev
force-pushed
the
main
branch
30 times, most recently
from
December 23, 2025 02:45
a05d3f0 to
c9b2647
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#18042
On first look, it seems to be an easy model to support as the HF implementation is pretty much the same as Qwen2.5VL
However, there are some very subtle differences that even some LLMs will miss (I tried both Grok and Gemini 3 and they both missed the 2 first points):
The embedding output was tested against HF transformers and confirmed to be matched
Testing
I'm using the ./tools/mtmd/test-1.jpeg already included in this repo:
llama-mtmd-cli -m ..... -mm ..... --image ./tools/mtmd/test-1.jpeg -p "extract all texts from this image" --temp 0 -n 1024Output: