Skip to content

PR - issue-652 Protoc fix from Google#664

Merged
authorjapps merged 1 commit into
masterfrom
issue-652_protoc
May 1, 2024
Merged

PR - issue-652 Protoc fix from Google#664
authorjapps merged 1 commit into
masterfrom
issue-652_protoc

Conversation

@nirmalchandra

@nirmalchandra nirmalchandra commented May 1, 2024

Copy link
Copy Markdown
Collaborator

protoc fix from Google. CI is Green now ✅

Fixes Issue

  • Which issue or ticket was(will be) fixed by this PR? (capture the issue number)

PR Branch
#ADD LINK TO THE PR BRANCH

Motivation and Context

Checklist:

  • New Unit tests were added

    • Covered in existing Unit tests
  • Integration tests were added

    • Covered in existing Integration tests
  • Test names are meaningful

  • Feature manually tested and outcome is successful

  • PR doesn't break any of the earlier features for end users

    • WARNING! This might break one or more earlier earlier features, hence left a comment tagging all reviewrs
  • Branch build passed in CI

  • No 'package.*' in the imports

  • Relevant DOcumentation page added or updated with clear instructions and examples for the end user

    • Not applicable. This was only a code refactor change, no functional or behaviourial changes were introduced
  • Http test added to http-testing module(if applicable) ?

    • Not applicable. The changes did not affect HTTP automation flow
  • Kafka test added to kafka-testing module(if applicable) ?

    • Not applicable. The changes did not affect Kafka automation flow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants