ISSUE-688 # Propagate exceptions from java api operations#690
Merged
javiertuya merged 1 commit intoOct 25, 2024
Conversation
authorjapps
approved these changes
Oct 20, 2024
Collaborator
Author
|
@authorjapps Now that I've collaborator access, I have a few questions about the PR workflow on this repo:
|
Owner
@javiertuya, Thanks for asking. In this case, yes, go ahead and merge it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate exceptions from java api operations
Fixes Issue
PR Branch
https://github.com/javiertuya/zerocode/tree/688-exceptions-java-api
Motivation and Context
When executing a java method that is invoked by the java api as an operation, any exception in the java method should be shown in the stacktrace to facilitate debugging. The executor exception handler should include this exception
Checklist:
New Unit tests were added
Integration tests were added
Test names are meaningful
Feature manually tested and outcome is successful
PR doesn't break any of the earlier features for end users
Branch build passed in CI
No 'package.*' in the imports
Relevant DOcumentation page added or updated with clear instructions and examples for the end user
Http test added to
http-testingmodule(if applicable) ?Kafka test added to
kafka-testingmodule(if applicable) ?