feat(spell-check): replace spell-check dictionaries to use AWF repositories#312
Merged
xmfcx merged 2 commits intoDec 18, 2025
Merged
Conversation
Shin-kyoto
approved these changes
Aug 27, 2024
Shin-kyoto
left a comment
Shin-kyoto
left a comment
There was a problem hiding this comment.
Thanks!! LGTM.
Can you change this workflow to required?
|
This pull request has been automatically marked as stale because it has not had recent activity. |
xmfcx
requested changes
Nov 30, 2024
|
This pull request has been automatically marked as stale because it has not had recent activity. |
Member
|
@mitsudome-r @xmfcx |
Member
Author
|
@HansRobo Thanks. I have applied the changes. |
Member
Author
|
@xmfcx I have applied your suggestion so could you re-review this PR? |
mitsudome-r
changed the title
…tories Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Mete Fatih Cırıt <mfc@autoware.org>
Contributor
|
@mitsudome-r could you rebase/update this pr to the latest main to re-trigger the ci? |
mitsudome-r
force-pushed
the
replace-spell-check-dict
branch
from
727f8d7 to
e599d59
Compare
xmfcx
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This modifies spell-check actions to use the dictionaries from AWF repository instead of TIER IV dictionaries so that we have full control over addition/deletion of words in the dictionaries without waiting approval from TIER IV.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.