feat: update runners to ubuntu-latest#388
Merged
Merged
Conversation
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
sasakisasaki
left a comment
sasakisasaki
left a comment
Contributor
There was a problem hiding this comment.
Thank you for fixing the workflow files! I guess it would be better to run a workflow with ubuntu-latest at least once.
Is there already running such the workflow with ubuntu-latest? Personally it is fine if a workflow for example build-and-tests succeeds.
Contributor
Author
|
@sasakisasaki -san thank you for the review but this workflow doesn't affect anything from build-and-test. Only modified workflows are these: And they don't depend on ROS. The rest are just readme updates. |
sasakisasaki
approved these changes
Dec 30, 2025
sasakisasaki
left a comment
sasakisasaki
left a comment
Contributor
There was a problem hiding this comment.
I understand, thank you! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since many actions are updated to node 24, I will switch everything back to
ubuntu-latest.runs-on: ubuntu-22.04withruns-on: ubuntu-latest.If you check commits, https://github.com/autowarefoundation/autoware-github-actions/pull/388/commits
Only the first one updates the workflows/actions themselves.
And they should work with latest ubuntu, no problems.
Tests performed
I don't think it's necessary for these.