add support for mongo driver v2. #124
Conversation
|
run the command make test.with_real_db, and the unit tests pass normally: |
… handshake, ptrutil) from the MongoDB Go Driver
| // Use of this source code is governed by an MIT-style license that can be found in | ||
| // the THIRD-PARTY-NOTICES file. | ||
|
|
||
| package assert |
There was a problem hiding this comment.
Thank you very much for your work.
I see that you copy a lot of code from other packages.
Could you just import them instead of copying?
The driver is a separate module, so there should be no problem.
There was a problem hiding this comment.
At first, I also wanted to write unit tests by importing the mongo-driver/v2 package, but this code is in the internal package and cannot be referenced externally. I had no choice but to use a copy-paste approach.
There was a problem hiding this comment.
Could you clarify, which internal code or method do you use?
mongo/v2 required go 1.21 so I don't undrstand why do you need go 1.17 copabilities for mongo/v2
There was a problem hiding this comment.
Could you clarify, which internal code or method do you use?
mongo/v2 required go 1.21 so I don't undrstand why do you need go 1.17 copabilities for mongo/v2
I copied this from https://github.com/mongodb/mongo-go-driver/tree/v2.0.0/internal. The official version is based on Go 1.18. Taking https://github.com/mongodb/mongo-go-driver/blob/v2.0.0/internal/assert/assertion_compare_go1.17_test.go as an example, the official repository has these Go files, and I brought them all over when I copied the entire folder.
There was a problem hiding this comment.
I asked which methods or code lines do you use.
I see that you use mtest.
As I see there is not mtest in v2 but there is MockDeployment.
add support for mongo driver v2