Revert ecr client changes for aws-sdk-go-v2 migration #4539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b90cd31.
singholt
approved these changes
Mar 20, 2025
danehlim
approved these changes
Mar 20, 2025
prateekchaudhry
changed the title
Merged
TheanLim
pushed a commit
to TheanLim/amazon-ecs-agent
that referenced
this pull request
Mar 28, 2025
TheanLim
pushed a commit
to TheanLim/amazon-ecs-agent
that referenced
this pull request
Apr 4, 2025
TheanLim
pushed a commit
to TheanLim/amazon-ecs-agent
that referenced
this pull request
Apr 7, 2025
TheanLim
pushed a commit
to TheanLim/amazon-ecs-agent
that referenced
this pull request
Apr 10, 2025
xxx0624
pushed a commit
to xxx0624/amazon-ecs-agent
that referenced
this pull request
Apr 17, 2025
TheanLim
pushed a commit
to TheanLim/amazon-ecs-agent
that referenced
this pull request
Apr 23, 2025
TheanLim
pushed a commit
to TheanLim/amazon-ecs-agent
that referenced
this pull request
Apr 23, 2025
TheanLim
pushed a commit
to TheanLim/amazon-ecs-agent
that referenced
this pull request
Apr 23, 2025
TheanLim
pushed a commit
to TheanLim/amazon-ecs-agent
that referenced
this pull request
Apr 24, 2025
TheanLim
added a commit
that referenced
this pull request
Apr 24, 2025
timj-hh
pushed a commit
to timj-hh/amazon-ecs-agent
that referenced
this pull request
Jul 19, 2025
timj-hh
pushed a commit
to timj-hh/amazon-ecs-agent
that referenced
this pull request
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR reverts changes introduced by PR #4512
This effectively migrates back ECR client back to aws-sdk-go from aws-sdk-go-v2 . This is being done because there aws-sdk-go-v2 ecr client fails to connect to ECR if customers specify a FIPS endpoint
Implementation details
git revert b90cd31
go mod tidy
go mod vendor
Testing
Manually testing the agent by running tasks against ECR FIPS endpoint
New tests cover the changes: No
Description for the changelog
bugfix: Revert ecr client to aws-sdk-go based one to enable ECR FIPS connectivity
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.