Add support for IPv6 targets to network-latency and network-packet-loss faults #4645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change extends support for network-latency and network-packet-loss faults to IPv6 targets. Today only IPv4 targets are accepted by these APIs but after this change IPv6 targets are accepted as well.
Implementation details
Request validation is changed for the APIs so that they accept IPv6 and IPv6 CIDR
Sources
(targets) andSourcesToFilter
(protected targets).tc
commands used for network-latency and network-packet-loss faults are updated so that -filter add
commands isall
instead ofip
.all
applies to all protocols whereasip
applies to IPv4 only.filter add
commands usesip
selector for IPv4 targets andip6
for IPv6 targets.Testing
Performed a variety of manual tests including the cases below.
In call cases above, the faults worked as expected. There was no network degradation for traffic to filtered targets but there was expected network degradation for traffic to destinations matching the targets.
New tests cover the changes: yes
Description for the changelog
Enhancement: Add support for IPv6 targets to network-latency and network-packet-loss faults
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Does this PR include the addition of new environment variables in the README?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.