clean up v1 credentials chain #4647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yiyuanzzz
changed the title
Yiyuanzzz
changed the title
ShelbyZ
approved these changes
May 21, 2025
mye956
approved these changes
May 27, 2025
xxx0624
added a commit
to xxx0624/amazon-ecs-agent
that referenced
this pull request
Jun 2, 2025
This reverts commit dede4b4.
timj-hh
pushed a commit
to timj-hh/amazon-ecs-agent
that referenced
this pull request
Jul 19, 2025
* clean up credentials chain for v1 * update windows test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
clean up v1 credentials chain since all the service clients have been migrated to v2
Implementation details
v2 credentials chain is already implemented.
Testing
New tests cover the changes:
Description for the changelog
enhencement: clean up v1 credentials chain
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.