Require ip6tables for fault injection capabilty on IPv6-only instances #4675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change makes
ip6tables
a required dependency for fault injection capability on IPv6-only instances. While the Agent already usesip6tables
to apply network-blackhole-port fault to IPv6 traffic (as implemented in PR #4629), this requirement is currently only enforced for IPv6-only tasks, remaining best-effort for other tasks.By making this change, the Agent will detect missing
ip6tables
dependency during instance registration for IPv6-only instances, preventing failures during fault injection. While we plan to consider enforcing IPv6 fault injection across all instance types in the future, this requires careful backwards-compatibility considerations. Since IPv6-only support is an upcoming feature, we can safely enforce this requirement for IPv6-only instances now without breaking existing functionality.Testing
Temporarily renamed
ip6tables
on an IPv6-only and a dual-stack instance and ran Agent.IPv6-only instance -
Dual-stack instance -
New tests cover the changes: yes
Description for the changelog
Enhancement: require
ip6tables
for fault injection capability on IPv6-only instancesAdditional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
no
Does this PR include the addition of new environment variables in the README?
no
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.