Set App.app to initial value of None to avoid AttributeError in teardown#2918
Merged
Conversation
freakboy3742
approved these changes
Oct 17, 2024
freakboy3742
left a comment
Member
There was a problem hiding this comment.
Seems entirely reasonable. Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the entire core test suite completes successfully. But at least one test (and probably others), when run individually, fail. Running
tests/style/pack/layout/test_rtl.pyby itself gets six instances of this:This is fine if a previous test has created an app instance, which is why it only fails in isolation. Changing it to a
hasattrcheck fixes it, but then it still needs an additional truthiness orNonecheck to avoid failingtest_window_created_without_app, which setsApp.apptoNone. At that point, why not just setNoneas the initial value in the class definition? It makes semantic sense for it to beNoneif there's no running app.PR Checklist: