Update window.py to be able to create dialogs in Textual#2949
Merged
Conversation
When trying to create a dialog using the Textual backend, I get a TypeError warning about too many inputs The code used works on GTK. This change solves that error
freakboy3742
approved these changes
Nov 13, 2024
freakboy3742
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix. Not sure where that bug leaked in, but this definitely fixes it!
As a minor adminstrative thing, I've added the changenote file that was causing CI to fail - if you're getting into Toga contribution, it would be worth reading through our contribution guide. That document contains lots of details about how to set up to test your code, and other requirements that we have related to submissions to the project.
Contributor
Author
|
Thank you for the help getting it merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to create a dialog using the Textual backend, I get a TypeError warning about too many inputs
The code used works on GTK.
This change solves that error
PR Checklist: