Skip to content

Update window.py to be able to create dialogs in Textual#2949

Merged
freakboy3742 merged 2 commits into
beeware:mainfrom
Codep3:patch-1
Nov 13, 2024
Merged

Update window.py to be able to create dialogs in Textual#2949
freakboy3742 merged 2 commits into
beeware:mainfrom
Codep3:patch-1

Conversation

@Codep3

@Codep3 Codep3 commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

When trying to create a dialog using the Textual backend, I get a TypeError warning about too many inputs
The code used works on GTK.
This change solves that error

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Codep3 and others added 2 commits November 12, 2024 16:57
When trying to create a dialog using the Textual backend, I get a TypeError warning about too many inputs
The code used works on GTK.
This change solves that error

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Not sure where that bug leaked in, but this definitely fixes it!

As a minor adminstrative thing, I've added the changenote file that was causing CI to fail - if you're getting into Toga contribution, it would be worth reading through our contribution guide. That document contains lots of details about how to set up to test your code, and other requirements that we have related to submissions to the project.

@freakboy3742 freakboy3742 merged commit 2697441 into beeware:main Nov 13, 2024
@Codep3

Codep3 commented Nov 14, 2024

Copy link
Copy Markdown
Contributor Author

Thank you for the help getting it merged!
If I find anything else I can contribute to, I'll go through the guide and set up the dev environment, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants