Move _package_version to travertino#3183
Merged
Merged
Conversation
mhsmith
force-pushed
the
travertino-package-version
branch
from
d32fc7c to
615251d
Compare
freakboy3742
requested changes
Feb 11, 2025
freakboy3742
left a comment
freakboy3742
left a comment
Member
There was a problem hiding this comment.
One comment inline about references to toga inside travertino.
The implicit imports in toga-cocoa/__init__.py et al should also be updated, so we're importing from a canonical location.
Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
approved these changes
Feb 13, 2025
freakboy3742
left a comment
freakboy3742
left a comment
Member
There was a problem hiding this comment.
Missed one usage in toga-dummy (which I've added), but otherwise looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that Toga is pinned to a specific version of Travertino, we can consolidate the two copies of this code.