Cache app paths#3544
Merged
Merged
Conversation
freakboy3742
approved these changes
Jun 9, 2025
freakboy3742
left a comment
freakboy3742
left a comment
Member
There was a problem hiding this comment.
👍 A small optimisation, but worth it - thanks!
freakboy3742
pushed a commit
to freakboy3742/toga
that referenced
this pull request
Jun 14, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since there's no reason the locations of these paths should change, we might as well cache them.
I also did a little cleanup on the backends — mostly reducing the number of intermediary Path objects via f-strings, and bundling up the common logic in Windows into a cached property. I don't know of any particular reason why the underscore on Android's
_contextwas doubled.(This is right next to, but shouldn't conflict with, #3543.)
PR Checklist: