Skip to content

Fix Intermittent WebView failures on Apple Platforms#3557

Merged
freakboy3742 merged 7 commits into
beeware:mainfrom
johnzhou721:patch-8
Jun 15, 2025
Merged

Fix Intermittent WebView failures on Apple Platforms#3557
freakboy3742 merged 7 commits into
beeware:mainfrom
johnzhou721:patch-8

Conversation

@johnzhou721

Copy link
Copy Markdown
Contributor

Fixes #3502.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Comment thread testbed/tests/widgets/test_webview.py Outdated
Comment thread testbed/tests/widgets/test_webview.py Outdated
@johnzhou721

Copy link
Copy Markdown
Contributor Author

Just tested another time -- it seems like the issue is resolved! The rest of the logic goes similarly to the case where Android returns None.

@johnzhou721

Copy link
Copy Markdown
Contributor Author

And... the logic on Android can now be simplified!

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me; lets see if it works as a long term fix...

@freakboy3742 freakboy3742 merged commit 07b7280 into beeware:main Jun 15, 2025
52 checks passed
@johnzhou721

Copy link
Copy Markdown
Contributor Author

Well let’s merge main into my other PR to see what happens…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent (and Recently Consistent) CI Failure on Javascript for macOS x86_64 (and Other Apple Platforms)

2 participants