Add Easy Media Server success story#3593
Merged
Merged
Conversation
HalfWhitt
requested changes
Jun 29, 2025
HalfWhitt
left a comment
HalfWhitt
left a comment
Member
There was a problem hiding this comment.
Hi, thanks for the contribution! Always happy to get more Toga success stories. Just two things:
- Change notes are listed in the release note, so they should be phrased in passive third person, e.g. "Such-and-so feature has been added."
- We like to mention the platform(s) for each app — looks like this one's macOS specific?
HalfWhitt
approved these changes
Jun 30, 2025
HalfWhitt
left a comment
HalfWhitt
left a comment
Member
There was a problem hiding this comment.
I made a slight tweak to make the change note more of a complete sentence, but otherwise this looks fine to me. Thanks for the PR, and for using Toga! : )
Member
|
Oh, one more thing — for future PRs, it's better do make a new branch for yourself rather than working directly on your main. No worries here, except you'll get a merge conflict next time you pull an update. Should be able to force it though, discarding local differences. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Easy Media Server success story to the docs
PR Checklist: