-
Notifications
You must be signed in to change notification settings - Fork 247
chore(storage): Consolidate deposits storage 3/3 #2774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abi87
wants to merge
44
commits into
consolidate-deposits-storage-pt2
Choose a base branch
from
consolidate-deposits-storage
base: consolidate-deposits-storage-pt2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore(storage): Consolidate deposits storage 3/3 #2774
abi87
wants to merge
44
commits into
consolidate-deposits-storage-pt2
from
consolidate-deposits-storage
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## consolidate-deposits-storage-pt2 #2774 +/- ##
====================================================================
- Coverage 60.59% 60.44% -0.15%
====================================================================
Files 357 357
Lines 17027 17137 +110
====================================================================
+ Hits 10318 10359 +41
- Misses 5891 5951 +60
- Partials 818 827 +9
🚀 New features to boost your workflow:
|
abi87
commented
May 17, 2025
storage/deposit/store.go
Outdated
|
||
// KVStore is a simple KV store based implementation that assumes | ||
// the deposit indexes are tracked outside of the kv store. | ||
type KVStore struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this KV store moved to v1 folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally hooking up depositsV2 code to production