Skip to content

Conversation

abi87
Copy link
Collaborator

@abi87 abi87 commented May 17, 2025

Finally hooking up depositsV2 code to production

@abi87 abi87 self-assigned this May 17, 2025
Copy link

codecov bot commented May 17, 2025

Codecov Report

❌ Patch coverage is 48.42767% with 82 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.44%. Comparing base (142d248) to head (1217324).

Files with missing lines Patch % Lines
cli/commands/deposit/db_check.go 0.00% 41 Missing ⚠️
beacon/blockchain/deposit.go 8.33% 9 Missing and 2 partials ⚠️
beacon/validator/block_builder.go 42.10% 9 Missing and 2 partials ⚠️
state-transition/core/validation_deposits.go 70.27% 8 Missing and 3 partials ⚠️
beacon/blockchain/init_chain.go 33.33% 4 Missing and 2 partials ⚠️
cli/commands/deposit/commands.go 0.00% 1 Missing ⚠️
state-transition/core/state_processor_staking.go 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                         Coverage Diff                          @@
##           consolidate-deposits-storage-pt2    #2774      +/-   ##
====================================================================
- Coverage                             60.59%   60.44%   -0.15%     
====================================================================
  Files                                   357      357              
  Lines                                 17027    17137     +110     
====================================================================
+ Hits                                  10318    10359      +41     
- Misses                                 5891     5951      +60     
- Partials                                818      827       +9     
Files with missing lines Coverage Δ
chain/spec.go 68.70% <100.00%> (+0.43%) ⬆️
config/spec/devnet.go 100.00% <100.00%> (ø)
config/spec/mainnet.go 100.00% <100.00%> (ø)
config/spec/testnet.go 100.00% <100.00%> (ø)
storage/deposit/store.go 69.29% <100.00%> (+3.24%) ⬆️
storage/deposit/v2/store.go 64.88% <100.00%> (+0.54%) ⬆️
cli/commands/deposit/commands.go 0.00% <0.00%> (ø)
state-transition/core/state_processor_staking.go 65.16% <95.83%> (+3.45%) ⬆️
beacon/blockchain/init_chain.go 32.50% <33.33%> (-5.34%) ⬇️
beacon/blockchain/deposit.go 36.58% <8.33%> (-4.26%) ⬇️
... and 3 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


// KVStore is a simple KV store based implementation that assumes
// the deposit indexes are tracked outside of the kv store.
type KVStore struct {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this KV store moved to v1 folder

@abi87 abi87 changed the base branch from main to consolidate-deposits-storage-pt2 May 20, 2025 10:14
@abi87 abi87 changed the title chore(storage): a more efficient deposits storage chore(storage): Consolidate deposits storage 3/3 May 20, 2025
@abi87 abi87 marked this pull request as ready for review May 20, 2025 11:36
@abi87 abi87 requested a review from a team as a code owner May 20, 2025 11:36
@abi87 abi87 deployed to test-e2e August 25, 2025 19:41 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant