-
Notifications
You must be signed in to change notification settings - Fork 247
chore(storage): Consolidate deposits storage 2/3 #2779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abi87
wants to merge
23
commits into
main
Choose a base branch
from
consolidate-deposits-storage-pt2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2779 +/- ##
==========================================
+ Coverage 60.53% 60.59% +0.05%
==========================================
Files 356 357 +1
Lines 16824 17027 +203
==========================================
+ Hits 10185 10318 +133
- Misses 5841 5891 +50
- Partials 798 818 +20
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce deposit store v2 which leverate a IAVL store to efficiently calculate deposits root.
While v1 needs to load all historical deposits and hash them together to get said root, which is a O(N) operation, the merkleDB allows doing it with O( log N) complexity (what it takes to recalculate the root of an append only tree), at the cost of somewhat larger storage (in a complete binary tree, there are as many intermediate nodes as leaves, so say double storage).
Data migration code is added, which allow a coordinate transfer of deposits from storeV1 to storeV2 but code is not hooked up to production code.