Fixing hybrid conversion bug that caused naming errors #283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was brought to attention by cases like this:
There is a name-resolution bug during hybrid conversion that causes
nation_name
to be incorrectly changed tonation_name_0
when used as a child reference to the data being partitioned, which causes a key error during relational conversion when it looks for$0.nation_name_0
in the expression dictionary but can't find it.The fix is to avoid the invocation of
nation_name
in the secondCALCULATE
causing an extra renaming since it is just a re-invocation of the same term.