Add verification for has/hasnot to ensure input is a collection #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a collection, and checking it is a collection, as well as other operator tests [RUN CI]
knassre-bodo
commented
Apr 1, 2025
Comment on lines
-151
to
+156
| HAS = ExpressionFunctionOperator("HAS", True, AllowAny(), ConstantType(BooleanType())) | ||
| HAS = ExpressionFunctionOperator( | ||
| "HAS", True, RequireCollection(), ConstantType(BooleanType()) | ||
| ) | ||
| HASNOT = ExpressionFunctionOperator( | ||
| "HASNOT", True, AllowAny(), ConstantType(BooleanType()) | ||
| "HASNOT", True, RequireCollection(), ConstantType(BooleanType()) |
There was a problem hiding this comment.
These verifier objects are assigned to each operator, and provide much higher quality error messages when the operands have an issue. Right now, most operators have weak/nonexistent verifiers, but eventually we will add proper verifiers for everything.
knassre-bodo
commented
Apr 1, 2025
Comment on lines
+92
to
+105
| pytest.param( | ||
| TableCollectionInfo("Customers") | ||
| ** WhereInfo( | ||
| [SubCollectionInfo("orders")], | ||
| FunctionInfo( | ||
| "HAS", | ||
| [ | ||
| ChildReferenceExpressionInfo("order_date", 0), | ||
| ], | ||
| ), | ||
| ), | ||
| "Invalid operator invocation 'HAS(orders.order_date)': Expected a collection as an argument, received an expression", | ||
| id="has_on_expression", | ||
| ), |
There was a problem hiding this comment.
This test is the the equivalent of Customers.WHERE(HAS(orders.order_date)), and shows the error message we would receive in this case. The XxxInfo classes are helpers that exist for creating QDAG nodes (one of the IR datastructures). The ** operator is used to chain these qdag nodes together when they are built (e.g. X ** WhereInfo(...) means build X, then build & return a WHERE clause with X as its predecessor)
J-Solano-bodo-ai
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #316 . Ensures the argument is a collection, and provides a clean error message if it isn't.