Skip to content

Fixing NDISTINCT so its output is 0 instead of NULL #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

Fixing NDISTINCT so its output is 0 instead of NULL #334

merged 1 commit into from
Apr 16, 2025

Conversation

knassre-bodo
Copy link
Contributor

Adding a bugfix to the behavior of NDISTINCT to have the same zero-coalescing behavior as COUNT.

@knassre-bodo knassre-bodo added the bug Something isn't working label Apr 16, 2025
@knassre-bodo knassre-bodo requested a review from vineetg3 April 16, 2025 18:06
vineetg3
vineetg3 approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@vineetg3 vineetg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@knassre-bodo knassre-bodo merged commit 8d5bf63 into main Apr 16, 2025
5 checks passed
@knassre-bodo knassre-bodo deleted the kian/fix_ndistinct branch April 16, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vineetg3 vineetg3 vineetg3 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knassre-bodo @vineetg3