Skip to content

Fixing bug with test broker_gen2 #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

Fixing bug with test broker_gen2 #392

merged 1 commit into from
Jul 10, 2025

Conversation

knassre-bodo
Copy link
Contributor

The actual defog SQL text is as follows:

SELECT COUNT(t.sbTxCustId) AS transaction_count
FROM sbTransaction AS t
JOIN sbCustomer AS c ON t.sbTxCustId = c.sbCustId
WHERE c.sbCustJoinDate >= date('now', '-70 days')

But the current PyDough implemnetation uses DATETIME("now", "-70 days") which does not truncate to the start of the day. To fix this, changed it to DATETIME("now", "-70 days", "start of day") so it is the same as the refsol.

@knassre-bodo knassre-bodo requested a review from juankx-bodo July 10, 2025 18:54
Copy link
Contributor

@juankx-bodo juankx-bodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lets wait for the CI tests to complete.

@knassre-bodo knassre-bodo merged commit bfdebac into main Jul 10, 2025
5 checks passed
@knassre-bodo knassre-bodo deleted the kian/fix_broker_gen2 branch July 10, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants