[BSE-4220] Support for converting an Aggregate to SQLGlot #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njriasan
commented
Nov 20, 2024
| @@ -96,6 +102,17 @@ def mkglot(expressions: list[Expression], _from: Expression, **kwargs) -> Select | |||
| return query | |||
|
|
|||
|
|
|||
| def mkglot_func(op: type[Expression], args: list[Expression]) -> Expression: | |||
There was a problem hiding this comment.
I know it makes code more verbose, but I'd rather have the type stability of passing a list instead of *args.
There was a problem hiding this comment.
Fair, but there is a loophole around that:
def mkglot_func(op: type[Expression], *args: list[Expression]) -> Expression:
arguments: list[Expression] = []
for arg in args:
assert isinstance(arg, Expression)
arguments.append(arg)
knassre-bodo
approved these changes
Nov 20, 2024
| @@ -96,6 +102,17 @@ def mkglot(expressions: list[Expression], _from: Expression, **kwargs) -> Select | |||
| return query | |||
|
|
|||
|
|
|||
| def mkglot_func(op: type[Expression], args: list[Expression]) -> Expression: | |||
There was a problem hiding this comment.
Fair, but there is a loophole around that:
def mkglot_func(op: type[Expression], *args: list[Expression]) -> Expression:
arguments: list[Expression] = []
for arg in args:
assert isinstance(arg, Expression)
arguments.append(arg)| input=Aggregate( | ||
| input=build_simple_scan(), | ||
| keys={ | ||
| "b": make_relational_column_reference("b"), |
There was a problem hiding this comment.
I'm still very much in favor of "let's give this a much shorter name"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles safely converting an aggregate to SQLGlot. As with other nodes there are likely missed optimizations to allow fusing select statements.