[BSE-4250] Infrastructure for converting Relational to SQL #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njriasan
changed the title
knassre-bodo
approved these changes
Nov 20, 2024
| input=build_simple_scan(), | ||
| ordered_columns=[("b", make_relational_column_reference("b"))], | ||
| ), | ||
| "SELECT b FROM table", |
pydough/sqlglot/relational_to_sql.py
Outdated
Comment on lines
16
to
17
| # Cache a visitor for the module | ||
| _visitor: SQLGlotRelationalVisitor = SQLGlotRelationalVisitor() |
There was a problem hiding this comment.
I advise against having a single defined visitor. When we get around to redefining how function translation works, the binding setup will likely be dialect-dependant, and each visitor will accordingly need its own bindings based on the dialect (or even on any functions the user defines in context). For the sake of flexibility, I advise we instead define some kind of datastructure that can host multiple visitors, at minimum broken up by dialect. For now, we'll only ever create & use one of them.
There was a problem hiding this comment.
Sure. I can move it out here since this is an over optimization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the basic support for converting relational to SQL. This is a simple test for the most basic functionality + API. The followup PR will add tests for every type of operator.