[BSE-4285] Add remaining sample TPC-H outputs #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
nick/add_remaining_tpch_outputs
to
nick/fix_test_matrix
November 26, 2024 15:40
njriasan
commented
Nov 26, 2024
| Expected output for TPC-H query 20. Note: This is truncated to | ||
| the first 10 rows. | ||
|
|
||
| This query needs manual rewriting to run efficiently in SQLite |
There was a problem hiding this comment.
This is an example of a query I had to manually rewrite into a subquery by hand, so its possible that the result is wrong. I think my rewrite was correct but we might only know when comparing to our PyDough results.
There was a problem hiding this comment.
Can you confirm by checking the Snowflake output against this?
There was a problem hiding this comment.
The random data will be different, so unfortunately no.
knassre-bodo
approved these changes
Nov 27, 2024
| Expected output for TPC-H query 20. Note: This is truncated to | ||
| the first 10 rows. | ||
|
|
||
| This query needs manual rewriting to run efficiently in SQLite |
There was a problem hiding this comment.
Can you confirm by checking the Snowflake output against this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the remaining outputs. It's possible some outputs are incorrect because I had to manually rewrite a couple queries to get them to compute in SQLite (clear drawback of being OLTP). We probably need to avoid these queries for the demo unless we can prove PyDough has such an improved query construction that they run faster. I've marked the queries in the outputs.