Skip to content

Add failing tests #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add failing tests #1034

wants to merge 2 commits into from

Conversation

michaeljones
Copy link
Collaborator

These are tests that have been deleted from the main 'merge-target' branch as they are failing and I'm not sure exactly how to fix them up.

Base automatically changed from merge-target to main July 8, 2025 19:02
@Rouslan
Copy link
Contributor

Rouslan commented Jul 13, 2025

I took a look at this branch and one change seems to be causing a problem.

In "renderer/sphinxrenderer.py", you replaced

cname = split_name(nodeDef.compoundname)

with

# strip out any template arguments before splitting on '::', to
# avoid errors if a template specialization has qualified arguments
# (see examples/specific/cpp_ns_template_specialization)
cleaned_name, _sep, _rest = nodeDef.compoundname.partition("<")
cname = split_name(cleaned_name)

but on my system, this change only causes test_example[index] and test_example[ns_template_specialization] to fail, because the same name is given for a template and its specialization. Could you try changing it back and checking again to see if the old version causes any problems?

@michaeljones
Copy link
Collaborator Author

@Rouslan - thank you for checking this out. It was an attempt to resolve the merge conflict with the change introduced by this PR #1012 but I confess I did it purely from a conflict resolution standard point and without the underlying understanding of the code. I can see that you've commented in that PR now that I check it out.

I can revert back to your version of things if you feel like your work already resolves the issue being address in #1012.

@Rouslan
Copy link
Contributor

Rouslan commented Jul 13, 2025

@michaeljones I see. Yes, I fixed this in my branch, without needing to strip out template arguments.

These are tests that have been deleted from the main 'merge-target'
branch as they are failing and I'm not sure exactly how to fix them
up.
I previously attempted to merge in the work done in:

  #1012

But Rouslan has said that the merge is unnecessary as the new work on
the refactor branch handles this situation correctly already.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants