[PLAT-8912] Review session definition #1820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 43.19 kB |
13.21 kB |
| After | 43.17 kB |
13.21 kB |
| ± | -19 bytes |
No change |
code coverage diff
| Ok | File | Lines | Branches | Functions | Statements |
|---|---|---|---|---|---|
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-navigation-breadcrumbs/navigation-breadcrumbs.js | 85.71% (-0.34%) |
64.29% (+5.03%) |
71.43% (+0%) |
84.31% (+1.29%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-simple-throttle/throttle.js | 100% (+0%) |
100% (+0%) |
100% (+20%) |
100% (+8.33%) |
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 87.27%(+0%) | 75.58%(+0.06%) | 86.86%(+0.09%) | 86.24%(+0.03%) |
Bumps macOS builds to 11
This configuration in particular seems to be incredibly unstable, doing more to reduce confidence in the test suite rather than shore up confidence in the changes being made. Builds hang after "Starting Selenium driver" somewhat consistently, then timing out after maximum wait time. Some recent examples: * https://buildkite.com/bugsnag/bugsnag-js-browser/builds/2677#018364be-9339-4b60-ac93-8e6df37ba792 * https://buildkite.com/bugsnag/bugsnag-js-browser/builds/2684#0183667b-b10e-4a10-9390-52e25b3f725f * https://buildkite.com/bugsnag/bugsnag-js-browser/builds/2689#01837982-63a7-49a1-a76b-95589934c1d9 * https://buildkite.com/bugsnag/bugsnag-js-browser/builds/2691#01837f1f-3fe9-4d06-bd8d-fce070950c7a Similar issues occur in the Safari 15 build, but given its the only representation for tests against that browser (and was at least *somewhat* more stable), did not warrant the same response.
gingerbenw
requested review from
djskinner,
gareththackeray,
kattrali and
tomlongridge
djskinner
reviewed
Sep 29, 2022
djskinner
reviewed
Sep 29, 2022
packages/plugin-navigation-breadcrumbs/navigation-breadcrumbs.js
Outdated
Show resolved
Hide resolved
Co-authored-by: djskinner <[email protected]>
djskinner
reviewed
Sep 29, 2022
| if (typeof client.resetEventCount === 'function') client.resetEventCount() | ||
| // if the client is operating in auto session-mode, a new route should trigger a new session | ||
| if (client._config.autoTrackSessions) client.startSession() | ||
| if (resetEventCount && typeof client.resetEventCount === 'function') client.resetEventCount() |
There was a problem hiding this comment.
consider testing this (at integration level?) or is there already e2e tests
djskinner
approved these changes
Sep 29, 2022
gareththackeray
approved these changes
Sep 29, 2022
…nag/bugsnag-js into PLAT-8912-review-session-definition
…s to version `2.62` to avoid kotlin version conflicts
…ility-error Lock `react-native-gesture-handler` verion in the RN test fixture
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
To prevent
replaceStateorpushStatefrom starting a new session. Ensuring Bugsnag sessions in the browser will start when, and only when, a page is loaded and Bugsnag is started.Changeset
Updated
wrapHistoryFnto no longer start a new sessionUpdated
wrapHistoryFnto accept aresetEventCountparameter, enabled onpushStateTesting
Removed tests to check when a new session is started